Skip to content

Implement method for finding current weather by zipcode #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Gilmoursa
Copy link

Create method for finding current weather by zipcode.

api.rb

#Zip format : 33704,US
#Usage: OpenWeather::Current.zip('33704,Us')
    def zip(zip, options ={})
      new(options.merge(zip: zip)).retrieve
    end

@manusajith
Copy link

@Gilmoursa can you have a look at why the spec is failing.

@Gilmoursa
Copy link
Author

I didn't write a spec for the zip method. I'm not sure why the spec is failing in Travis CI. I ran bundle exec rspec in terminal and I have 39 tests passing and 0 failures.

@vanboom
Copy link

vanboom commented Nov 21, 2016

👍

@valerybugakov
Copy link

@manusajith is there a way to help with merge of this PR? Would love to have zipcode method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants