Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containerization support #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add containerization support #32

wants to merge 3 commits into from

Conversation

danielsp45
Copy link
Member

No description provided.

@danielsp45 danielsp45 self-assigned this Mar 17, 2023
@danielsp45 danielsp45 force-pushed the dp/add-docker-configs branch from e45489e to 33e551d Compare March 17, 2023 19:47
@danielsp45 danielsp45 force-pushed the dp/add-docker-configs branch from 33e551d to 9ce2a39 Compare March 17, 2023 20:03
nelsonmestevao
nelsonmestevao reviewed Mar 17, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@nelsonmestevao nelsonmestevao changed the title Added containerization support Add containerization support Mar 19, 2023
@danielsp45 danielsp45 force-pushed the dp/add-docker-configs branch from 4304fe9 to b28fb3e Compare March 19, 2023 23:34
@danielsp45
Copy link
Member Author

@nelsonmestevao can you check if what I included in the .dockerignore file is enough? 🙏

ruilopesm
ruilopesm reviewed Mar 26, 2023
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to add docker-compose commands to the repo README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonmestevao nelsonmestevao nelsonmestevao approved these changes

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

Assignees

@danielsp45 danielsp45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielsp45 @nelsonmestevao @ruilopesm