feat: add support for private GitHub repository cloning with OAuth authentication #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement token-based authentication for cloning private GitHub repositories. - Modify _check_repo_exists to use GitHub API for repo existence check with authentication. - Update clone_repo to handle token-based URLs for private repos. - Add .qodo/ to .gitignore.
- Introduce OAuth authentication with GitHub to handle private repositories. - Modify clone_repo to accept a token for authenticated cloning. - Implement OAuth routes for login and logout in src/server/oauth.py. - Update navbar to display login/logout options based on authentication status. - Add session middleware to manage user sessions. - Update query_processor to pass user token for private repo access. - Add Authlib and itsdangerous to requirements.txt for OAuth functionality.
|
I'm still working on adding new tests and updating the existing ones |
JulsdL
changed the title
…clone options - Update clone_repo tests to verify that the private repository token is correctly passed to _check_repo_exists. - Refactor test_clone_repo_with_commit and test_clone_repo_without_commit to inspect git command arguments (e.g. ensuring --recurse-submodules, shallow clone flags, and checkout behavior). - Update error message expectations for nonexistent repositories. - Streamline assertions in tests for invalid URLs and local paths. - Refactor tests for custom branches and commit checkouts to verify proper argument order and flag usage. - Add new tests to validate proper behavior for private repositories: one for a valid token scenario and one for missing token handling.
…/failure, logout) and update template directory path to src/server/templates.
|
cool ! |
|
Hi, Thanks for your work on implementing private repository access via GitHub OAuth. I’ve been exploring a slightly different approach that uses directly provided Personal Access Tokens (PATs) via a new I noticed that both approaches modify some of the same core files, so they wouldn’t be compatible right away. That being said, I'm perfectly fine with closing my PR if the OAuth approach is preferred, but I wanted to throw this idea out there for discussion or potential collaboration. Thanks again for all your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub OAuth Integration for Private Repositories
This update introduces comprehensive support for handling private GitHub repositories by integrating GitHub OAuth authentication. The key updates include:
🔑 Authentication & Repository Access
1. Secure Repository Cloning
clone_repofunction: Now accepts an optional OAuth token._check_repo_existsnow verifies the repository using authentication headers.2. OAuth Authentication Routes
src/server/oauth.py.3. Session Middleware for Token Management
src/server/main.py.query_processor) to access and pass tokens toclone_repo.🖥️ UI & User Experience
4. Authentication UI Updates
navbar.jinja:📖 Documentation & Configuration
5. Updated README.md
🛠️ Miscellaneous Enhancements
6. Additional Improvements
.gitignoreupdates: Ignores new directories.requirements.txtupdates: Adds dependencies for:AuthlibitsdangerousThese changes enhance security, usability, and documentation, enabling seamless private repository integration via GitHub OAuth. 🚀
