fix: construct full path for workspaceLogPath instead of just filename #554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The VS Code extension was failing to open SSH proxy log files with the error:
This occurred because
workspaceLogPath
was being set to just the filename instead of the full path, causing VS Code to look for the file in the wrong location.Solution
Modified the code in
src/remote.ts
to properly construct the full path usingpath.join(logDir, logFileName)
instead of just storing the filename.Before:
After:
Testing
/tmp/coder-logs/coder-ssh-20250716-123428-qvict-90716.log
This fix ensures that when users configure the
coder.proxyLogDirectory
setting and use the "View Logs" command, VS Code can successfully open the SSH proxy log files.