Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add jeanp413.open-remote-ssh as candidate remote SSH extension. #467

Merged
merged 6 commits into from
Apr 8, 2025

Conversation

asgeirn
Copy link
Contributor

@asgeirn asgeirn commented Apr 3, 2025

Tested on VSCodium Version: 1.98.2
Release: 25078
Commit: c6286962b0f5f2c3ad5e558a439dc3fcfd20b2ac
Date: 2025-03-19T00:30:57.705Z
Electron: 34.3.2
ElectronBuildId: undefined
Chromium: 132.0.6834.210
Node.js: 20.18.3
V8: 13.2.152.41-electron.0
OS: Darwin arm64 24.4.0

Host: v2.20.0+03b5012

Closes #408

Tested on VSCodium Version: 1.98.2
Release: 25078
Commit: c6286962b0f5f2c3ad5e558a439dc3fcfd20b2ac
Date: 2025-03-19T00:30:57.705Z
Electron: 34.3.2
ElectronBuildId: undefined
Chromium: 132.0.6834.210
Node.js: 20.18.3
V8: 13.2.152.41-electron.0
OS: Darwin arm64 24.4.0

Host: v2.20.0+03b5012
Copy link
Contributor Author

@asgeirn asgeirn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the messages I get in the debug console:

CSRF token not found
CSRF token not found
CSRF token not found
CSRF token not found
CSRF token not found
CSRF token not found
(node:25464) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use VSCodium Helper (Plugin) --trace-deprecation ... to show where the warning was created)
CSRF token not found
CSRF token not found
CSRF token not found
(node:25559) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use VSCodium Helper (Plugin) --trace-deprecation ... to show where the warning was created)

@asgeirn asgeirn mentioned this pull request Apr 3, 2025
4 tasks
@matifali matifali requested review from f0ssel and code-asher April 3, 2025 11:04
@matifali
Copy link
Member

matifali commented Apr 3, 2025

This was previously considered in #441, but IIRC, there were a few issues, and it wasn't working as expected.
See: #441 (comment)

@asgeirn
Copy link
Contributor Author

asgeirn commented Apr 7, 2025

Is there any form of testing I could do on my setup to try to reproduce that issue? Because I was not seeing any issues in authenticating, browsing, launching and connecting to a workspace.

@matifali matifali marked this pull request as ready for review April 7, 2025 10:55
@matifali
Copy link
Member

matifali commented Apr 7, 2025

Thanks, @asgeirn. I did some testing, and it seems to work fine for me, too.

@matifali
Copy link
Member

matifali commented Apr 7, 2025

Can you update the Changelog and bump the version in package.json to v1.8.0? After that, we can publish a new release.

@asgeirn
Copy link
Contributor Author

asgeirn commented Apr 8, 2025

@matifali Done :)

@matifali
Copy link
Member

matifali commented Apr 8, 2025

Sorry for the misguidance on the version bump. We do that by directly pushing to main.

@matifali matifali merged commit 1119d9b into coder:main Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCodium/WindSurf/Cursor support
3 participants