fix: improve version extraction logic to prevent false positives #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves version extraction logic in the version bump script to prevent false positives when matching version fields. The changes make the pattern matching more specific by ensuring only exact version field matches are replaced, rather than matching any field containing "version" in its name.
Key changes:
- Enhanced regex patterns to match version fields more precisely using
^[[:space:]]*version[[:space:]]*=instead ofversion.*=.*" - Added explicit field name validation with
$1 == "version"check - Improved whitespace handling by preserving original indentation
matifali
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the version extract and replace logic more specific so it wont replace any field that does is not specifically
fieldunder the detected modules.Type of Change
Testing & Validation
bun test)bun fmt)Related Issues
#510