Skip to content

🤖 fix: allow file_edit_insert to create files implicitly #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2025
Merged

🤖 fix: allow file_edit_insert to create files implicitly #602

merged 4 commits into from
Nov 14, 2025
+25 −26

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Nov 14, 2025

Summary

  • let file_edit_insert write missing files without a special flag while keeping guard validation for existing files
  • describe the legacy create flag as a no-op and relax the schema instructions accordingly
  • expand unit tests to cover implicit creation plus the compatibility path

Testing

  • bun test src/services/tools/file_edit_insert.test.ts

_Generated with _

@ammario ammario merged commit 8e0a257 into main Nov 14, 2025
13 checks passed
@ammario ammario deleted the implicit-create-flag branch November 14, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammario ammario ammario approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ammar-agent @ammario