Skip to content

chore: disable version check in ci #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

chore: disable version check in ci #431

merged 3 commits into from
Apr 16, 2025

Conversation

matifali
Copy link
Member

Adhoc arrangement until we sort out #426

@matifali matifali self-assigned this Apr 16, 2025
@matifali matifali requested review from mafredri and defelmnq April 16, 2025 08:17
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp 👍

else
echo "No version mismatch detected. All versions are up to date."
fi
# Disbale version check until https://github.com/coder/modules/pull/426 is merged.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo Disable

echo "No version mismatch detected. All versions are up to date."
fi
# Disbale version check until https://github.com/coder/modules/pull/426 is merged.
# This will allsow us to use seperate Versioning for each module without failing CI. The backend already supports that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: allow

@matifali matifali enabled auto-merge (squash) April 16, 2025 08:22
@matifali matifali merged commit b3d50ac into main Apr 16, 2025
4 checks passed
@matifali matifali deleted the disable-version-check branch April 16, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants