impl: verify cli signature (#562) #1142
33 new problems found by Qodana Community for JVM
Qodana Community for JVM
33 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Usage of API marked for removal |
🔴 Failure | 13 |
Local 'var' is never modified and can be declared as 'val' |
🔶 Warning | 1 |
Incorrect string capitalization |
🔶 Warning | 1 |
Constant conditions |
🔶 Warning | 1 |
Usage of redundant or deprecated syntax or deprecated symbols |
🔶 Warning | 1 |
Throwable not thrown |
🔶 Warning | 1 |
Redundant nullable return type |
🔶 Warning | 1 |
Unused symbol |
🔶 Warning | 1 |
Convert 'object' to 'data object' |
◽️ Notice | 5 |
Class member can have 'private' visibility |
◽️ Notice | 3 |
String concatenation that can be converted to string template |
◽️ Notice | 2 |
Argument could be converted to 'Set' to improve performance |
◽️ Notice | 1 |
Return or assignment can be lifted out |
◽️ Notice | 1 |
Redundant lambda arrow |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
View the detailed Qodana report
To be able to view the detailed Qodana report, you can either:
- Register at Qodana Cloud and configure the action
- Use GitHub Code Scanning with Qodana
- Host Qodana report at GitHub Pages
- Inspect and use
qodana.sarif.json(see the Qodana SARIF format for details)
To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:
- name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 74 in src/main/kotlin/com/coder/gateway/util/LinkHandler.kt
github-actions / Qodana Community for JVM
Local 'var' is never modified and can be declared as 'val'
Variable is never modified, so it can be declared using 'val'
github-actions / Qodana Community for JVM
Argument could be converted to 'Set' to improve performance
The argument can be converted to 'Set' to improve performance
Check notice on line 10 in src/main/kotlin/com/coder/gateway/cli/gpg/VerificationResult.kt
github-actions / Qodana Community for JVM
Convert 'object' to 'data object'
'sealed' sub-object can be converted to 'data object'
Check notice on line 11 in src/main/kotlin/com/coder/gateway/cli/downloader/DownloadResult.kt
github-actions / Qodana Community for JVM
Convert 'object' to 'data object'
'sealed' sub-object can be converted to 'data object'
Check notice on line 12 in src/main/kotlin/com/coder/gateway/cli/downloader/DownloadResult.kt
github-actions / Qodana Community for JVM
Convert 'object' to 'data object'
'sealed' sub-object can be converted to 'data object'
Check notice on line 7 in src/main/kotlin/com/coder/gateway/cli/gpg/VerificationResult.kt
github-actions / Qodana Community for JVM
Convert 'object' to 'data object'
'sealed' sub-object can be converted to 'data object'
Check notice on line 36 in src/main/kotlin/com/coder/gateway/util/URLExtensions.kt
github-actions / Qodana Community for JVM
Convert 'object' to 'data object'
'sealed' sub-object can be converted to 'data object'
Check notice on line 568 in src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt
github-actions / Qodana Community for JVM
String concatenation that can be converted to string template
'String' concatenation can be converted to a template
Check notice on line 666 in src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt
github-actions / Qodana Community for JVM
String concatenation that can be converted to string template
'String' concatenation can be converted to a template
Check warning on line 41 in src/main/kotlin/com/coder/gateway/util/Dialogs.kt
github-actions / Qodana Community for JVM
Incorrect string capitalization
String 'Choose IDE and project for workspace {0}' is not properly capitalized. It should have title capitalization
Check warning on line 100 in src/main/kotlin/com/coder/gateway/util/Retry.kt
github-actions / Qodana Community for JVM
Constant conditions
Condition 'e is ProcessCanceledException' is always false when reached
Check warning on line 277 in src/main/kotlin/com/coder/gateway/CoderRemoteConnectionHandle.kt
github-actions / Qodana Community for JVM
Usage of redundant or deprecated syntax or deprecated symbols
'connect(URI): ThinClientHandle' is deprecated. Use connect(URI, ExtractedJetBrainsClientData)
Check warning on line 272 in src/main/kotlin/com/coder/gateway/cli/CoderCLIManager.kt
github-actions / Qodana Community for JVM
Throwable not thrown
Throwable instance 'UnsignedBinaryExecutionDeniedException' is not thrown
Check notice on line 234 in src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
github-actions / Qodana Community for JVM
Return or assignment can be lifted out
'Assignment' can be lifted out of 'if'
Check failure on line 8 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal
Check failure on line 25 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal
Check failure on line 24 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal
Check failure on line 25 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'getOnlyBySettingsSelector()' is deprecated and marked for removal
Check failure on line 23 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'getPlainProxyPassword()' is deprecated and marked for removal
Check failure on line 23 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal
Check failure on line 22 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal
Check failure on line 24 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'PROXY_AUTHENTICATION' is deprecated and marked for removal
Check failure on line 25 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal
Check failure on line 22 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'getProxyLogin()' is deprecated and marked for removal
Check failure on line 24 in src/main/kotlin/com/coder/gateway/services/CoderRestClientService.kt
github-actions / Qodana Community for JVM
Usage of API marked for removal
'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal