chore: replace prettier with dprint #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
changed the title
johnstcn
commented
May 22, 2024
scripts/check_unstaged.sh
Outdated
There was a problem hiding this comment.
not technically needed, can remove
johnstcn
commented
May 22, 2024
| - name: Check formatting | ||
| run: yarn format:check | ||
| uses: dprint/check@v2.2 |
There was a problem hiding this comment.
matifali
reviewed
May 23, 2024
| "deprecated/*" | ||
| ], | ||
| "plugins": [ | ||
| "https://plugins.dprint.dev/markdown-0.17.0.wasm", |
There was a problem hiding this comment.
How do we keep these updated? I don't think dependabot supports this.
There was a problem hiding this comment.
Currently there isn't any automated way, but apparently warning about outdated plugin versions is on the roadmap.
|
Is packages.json still required as there is no node anymore? |
missed removing that, but it can also go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out https://github.com/dprint/dprint for formatting instead of prettier.
Also threw in
shfmtfor good measure.Note:
Dockerfile.$TAG -> $TAG.Dockerfiledue to an existing issue with dprint-plugin-dockerfile