fix: implement device auth rate limit handling #17079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugodutka
force-pushed
the
hugodutka/device-auth-retry-logic
branch
4 times, most recently
from
454488b to
a2957af
Compare
hugodutka
force-pushed
the
hugodutka/device-auth-retry-logic
branch
from
a2957af to
f61f16a
Compare
kylecarbs
approved these changes
Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth2 specification describes how clients in the device flow should handle retrying requests when they are rate limited.
We didn't respect it, which sometimes prevented users from logging in or setting up external auth. They'd see a
slow_downerror in the UI and would be unable to complete the authentication flow. This PR implements rate limit handling according to the spec.