Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set pipefail during make test #22

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: set pipefail during make test #22

merged 1 commit into from
Jan 14, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jan 14, 2025 •
edited
Loading

Tests that didn't compile got merged to main because pipefail wasn't set when piping the output of xcodebuild into xcpretty.

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Jan 14, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review January 14, 2025 05:58
@ethanndickson ethanndickson enabled auto-merge (squash) January 14, 2025 05:59
@ethanndickson ethanndickson requested a review from coadler January 14, 2025 05:59
@ethanndickson ethanndickson mentioned this pull request Jan 14, 2025
Merged
@ethanndickson ethanndickson merged commit 2f7f8f8 into main Jan 14, 2025
4 checks passed
This was referenced Jan 15, 2025
Merged
Merged
@ethanndickson ethanndickson deleted the ethan/xcpretty-pipefail branch January 23, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @coadler