Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable authentication module #4069

Closed
wants to merge 2 commits into from

Conversation

sdissegna-maystreet
Copy link
Contributor

This is the implementation of the suggestion described in #4068

feat: pluggable authentication system

See merge request ui/code-server!1
@sdissegna-maystreet sdissegna-maystreet requested a review from a team as a code owner August 30, 2021 12:11
@GirlBossRush
Copy link
Contributor

Thank you so much for this contribution! We’ll need some time to review this proposal, but I feel optimistic this is a feature that many users could find helpful.

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 30, 2021

This looks really neat! Thanks for opening an issue and adding. Like @TeffenEllis said, optimistic but we'll need to discuss a bit.

Don't worry about the Docs preview failing - we have an issue running that on forks. (see #4027)

As for Build/Pre-build, it looks like you'll need to adjust some of the unit tests. Let us know if you need any guidance in that area.

Are you planning on adding docs or an example for how you imagine someone might use this?

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 30, 2021

Okay, I just chatted with @code-asher briefly about this. We're going to start a discussion in your original issue.

According to our docs:

Please create a GitHub Issue that includes context for issues that you see. You can skip this if the proposed fix is minor.

Ideally, a change with large impact like this should be first discussed in an issue before a PR is opened. That way, we can ensure everyone is onboard and we understand how this will impact the community before the author begins implementing the feature. We'll leave this PR for now since this may not have been super clear.

We'll continue the discussion on the issue and see how we can figure out a way to move forward with this idea.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 13, 2021

Hey @sdissegna-maystreet - hope you saw the discussion here and the Plugin API discussion started here.

I'm going to close this PR but we would love to get your input on the Plugin API!

@jsjoeio jsjoeio closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants