Add support for a YAML config file #1619
Conversation
nhooyr
force-pushed
the
config
branch
3 times, most recently
from
3087930 to
4d239eb
Compare
|
Last thing for v3.3.0 is just the docs on all the changes. @code-asher Would be nice to have windows support as well, see #1397 |
nhooyr
force-pushed
the
config
branch
6 times, most recently
from
08b3775 to
6dddb4c
Compare
|
note: the login page should indicate the config location or whether the password was grabbed via $PASSWORD. |
nhooyr
force-pushed
the
config
branch
2 times, most recently
from
adf3703 to
fd919de
Compare
| throw error(`--${key} requires a value`) | ||
| } | ||
|
|
||
| if (option.type == OptionalString && value == "false") { |
There was a problem hiding this comment.
I'm curious what the use of this is? An optional string is a string? rather than boolean so this feels incorrect to me as it prevents the string value false.
I see it used in the default config file but since omission already has this meaning it doesn't seem to gain anything? Unless it's to provide an example to the user in which case I think we could add it as a comment.
There was a problem hiding this comment.
I could see it being nice to explicitly disable the cert in the configuration; we could definitely modify parse to handle this case but maybe we just don't worry about it until the cli library. No one's going to use a cert named false anyway.
There was a problem hiding this comment.
Yea the purpose was to disable the cert via the cli when it's set in the config.
- Error out if auth is enabled but no password is passed in - Indicate password location on login page
No description provided.