-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Support exporting pod stdout and result #399
Conversation
ui/src/components/Sidebar.tsx
Outdated
"href", | ||
"data:text/plain;charset=utf-8," + encodeURIComponent(data.exportJSON) | ||
); | ||
element.setAttribute("download", `${repoName || ""}.json`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add date to the exported filename and keep consistent with the .ipynb export.
codepod/ui/src/components/Sidebar.tsx
Lines 891 to 893 in 554cdac
const filename = `${ | |
repoName || "Untitled" | |
}-${new Date().toISOString()}.ipynb`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I made this minor change. Merging.
@@ -794,6 +794,8 @@ function CanvasImpl() { | |||
cellList = JSON.parse(String(fileContent)).cells.map((cell) => ({ | |||
cellType: cell.cell_type, | |||
cellSource: cell.source.join(""), | |||
cellOutputs: cell.outputs || [], | |||
execution_count: cell.execution_count || 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should display the execution count in the output area of a Code pod. This PR already gets packed, let's implement it in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
execution_count
is a property of both a code cell and its output (if the output type is execute_result
) #411
Thanks, Sen! |
Summary
Test