Skip to content

Casting multi_ptr pointers #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ProGTX
Copy link
Contributor

@ProGTX ProGTX commented Dec 19, 2018

This PR proposes the addition of pointer casting functions to SYCL in order to simplify casting of the multi_ptr class.

It adds the following functions:

  • static_pointer_cast
  • dynamic_pointer_cast
  • const_pointer_cast
  • reinterpret_pointer_cast

It also simplifies casting to a const variant of the multi_ptr, provides better handling of const qualifiers in general, and provides better handling of the void specialization.

@ProGTX ProGTX changed the title WIP: Casting multi_ptr pointers Casting multi_ptr pointers Jan 8, 2019
Copy link
Contributor

@Ruyk Ruyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

@ProGTX ProGTX force-pushed the ProGTX/multi_ptr_cast branch from 5f30562 to aa9b82c Compare September 21, 2019 08:18
@ProGTX
Copy link
Contributor Author

ProGTX commented Sep 21, 2019

I've removed the const and void changes which have been merged into SYCL-1.2.1 as errata.

@ProGTX ProGTX force-pushed the ProGTX/multi_ptr_cast branch from 6c9a4bf to bdf6159 Compare September 22, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants