fix(search): follow symlinks when walking docset directories - #30
Merged
Conversation
local_folder docsets are stored as symlinked directories. readdir() withFileTypes returns Dirent objects where isDirectory()/isFile() return false for symlinks — only isSymbolicLink() is true. walkFiles() was therefore skipping all symlinked content, causing files_count: 0. Fix: when entry.isSymbolicLink(), use stat() (which follows the link) to determine whether the target is a directory or file, then recurse/yield accordingly. Broken symlinks are silently skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
local_folder docsets are stored as symlinked directories. readdir() withFileTypes returns Dirent objects where isDirectory()/isFile() return false for symlinks — only isSymbolicLink() is true. walkFiles() was therefore skipping all symlinked content, causing files_count: 0.
Fix: when entry.isSymbolicLink(), use stat() (which follows the link) to determine whether the target is a directory or file, then recurse/yield accordingly. Broken symlinks are silently skipped.