Ignore blank and null entries in PATH search for mvn/gradle execs #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
With a null PATH entry on Windows finding the mvn command resolves to absolute path: "C:\mvn.cmd" which does not exist for me, so the dependency lib download fails.
Error log msgs like:
I noticed this on v1.1.0 but looking at the code it appears to exist in the main branch as well.
How Has This Been Tested?
Tested with an empty PATH entry on Windows
Breaking Changes
No
Types of changes
Checklist
Haven't tested
Additional context
I did a bit of searching to try to understand if an empty PATH entry should be considered meaningful, and found some leads suggesting it should mean the current directory. I didn't follow up on this though.
We wouldn't want to use
map(File::getAbsolutePath)if we wanted to find something in the current directory, so that would require a different solution. It might still be better to filter this case out until/unless it is clear we want to include it.