Migrate from deprecated URLEncoder to URI #2970
Open
+57
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java.net.URL has been deprecated in recent Java versions, so this commit migrates all usages to the recommended java.net.URI class. Changes: - ProtocolHelper.java: Convert URL to URI using toURI() method for ClassLoader resources, update protocol checks to use getScheme() instead of getProtocol() - FessXpathTransformer.java: Replace all URL instances with URI, use URI.create() and URI.resolve() for URL construction and relative URL resolution, update exception handling from MalformedURLException to IllegalArgumentException Note: fess-crawler library changes are handled separately as mentioned by the user.
Add URL-to-URI conversion layer to maintain compatibility with the fess-crawler parent class (XpathTransformer) which still uses java.net.URL. Changes: - getBaseUrl(): Return URL instead of URI, internally use URI.toURL() - addChildUrlFromTagAttribute(): Accept URL parameter and convert to URI internally for modern URL handling - This allows internal use of URI while maintaining API compatibility with the parent class Note: Once fess-crawler is updated to use URI, these compatibility conversions can be removed.
marevol
force-pushed
the
claude/migrate-url-to-uri-01EHW3q58TFX2EDC9qE4gNsG
branch
from
05f7232 to
d3a1596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.net.URL has been deprecated in recent Java versions, so this commit migrates all usages to the recommended java.net.URI class.
Changes:
Note: fess-crawler library changes are handled separately as mentioned by the user.