[권수형] 스프린트6(base branch 수정) #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lank가 포함된 링크에 rel="noopener noreferrer" 추가
…nationBar, DropdownButton 기능 구현
쓰로틀링을 추가한 resize hook을 이용하여 화면 사이즈마다 불러오는 item의 갯수를 다르게 설정
…의 각 페이지에 맞는 레이아웃을 개별 적용시킴
- Items.js -> items.js 파일명 변경 - AllItemsSection.jsx의 imgUrl 값 변경 - getItemDisplayLimit -> util함수로 추상화, 좀더 명확히 의도가 드러나게 getItemDisplayLimitByscreenSize으로 이름 변경 - DropdownButton.jsx에서 명확함을 위해 isClicked -> isDropdownOpen 변수명 변경 - Items 페이지에서 검색어가 입력된 상태에서 필터 옵션을 변경하면 검색어가 반영되지 않는 문제 - Search Input value State를 AllItemsSection.jsx으로 끌어올림
…change를 핸들하는 방식으로 변경 ( media 종류가 변경될때만 setState 실행) + 일부 변수명 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://awkward-panda-market.netlify.app/additem
close #86
Basic 브랜치에서 작업하여 PR한 것을 수정하여,
React 브랜치를 pull하고, 다시 React branch에 PR합니다.
코드리뷰를 반영하였습니다