Skip to content

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Oct 10, 2025

Description
This PR introduces an event system that enables users to observe and respond to various queue operations. The $keepDoneJobs option (previously optional and disabled by default) has been removed, as its functionality can now be managed through events.

Since RabbitMQ didn't support the $keepDoneJobs option, this update ensures consistent behavior across all handlers.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the enhancement New feature or request label Oct 10, 2025
@coveralls
Copy link

coveralls commented Oct 10, 2025

Pull Request Test Coverage Report for Build 18417128054

Details

  • 274 of 361 (75.9%) changed or added relevant lines in 7 files are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+11.7%) to 85.929%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Handlers/RabbitMQHandler.php 18 24 75.0%
src/Commands/QueueWork.php 64 78 82.05%
src/Handlers/PredisHandler.php 21 40 52.5%
src/Handlers/DatabaseHandler.php 19 40 47.5%
src/Handlers/RedisHandler.php 21 48 43.75%
Files with Coverage Reduction New Missed Lines %
src/Handlers/DatabaseHandler.php 1 67.61%
src/Handlers/PredisHandler.php 2 74.74%
src/Handlers/RabbitMQHandler.php 2 83.33%
src/Handlers/RedisHandler.php 2 67.54%
src/Commands/QueueWork.php 7 79.3%
Totals Coverage Status
Change from base Build 17724836360: 11.7%
Covered Lines: 1087
Relevant Lines: 1265

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants