Skip to content

feat(Badge) : add iconId and accentColor on Badge component #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yodeyer
Copy link

@yodeyer yodeyer commented May 2, 2025

Hello,

Here's a PR to be able to configure iconId and accentColor in Badge component.

Thank you

@enguerranws
Copy link
Collaborator

Hi!

I have some doubts about this feature: it would allow use cases for badges that are actually forbidden by the DSFR (see the Editorial Rules section here: https://www.systeme-de-design.gouv.fr/version-courante/fr/composants/badge).

In my view, the goal of react-dsfr is to implement the DSFR specs as closely as possible. That doesn’t mean it’s completely out of the question, but I think we should first check with the DSFR team to understand why this rule exists (in this case, it’s mentioned in the documentation) and see if it’s something that should be revised on their side before implementing it in react-dsfr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants