fix(http): bound Streamable HTTP session lifecycle - #63
Open
Seger85 wants to merge 3 commits into
Open
Conversation
Seger85
marked this pull request as ready for review
August 13, 2026 13:42
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound the lifetime and count of Streamable HTTP MCP sessions so abandoned client sessions cannot accumulate indefinitely in a long-running HTTP process.
What changes
onclosecallbacks deleting a newer session entryWhy
The HTTP server stores every initialized
StreamableHTTPServerTransportin a process-level map and previously removed it only when the transport'sonclosecallback fired. Clients that disappear without a clean close can therefore leave sessions retained for the lifetime of the Node process. In a long-running MCP endpoint this can grow heap usage over time.This PR fixes that lifecycle issue directly instead of relying on a larger V8 heap or periodic process restarts.
Validation
Validated from the repository base
99ce431aa81dd4cafc2879bd35b6ee3acd0f2d74on Node 24:tsc --noEmit: passedsrc: passed--pull=false: passedRuntime validation against the built HTTP server:
tools/listreturned HTTP 200No upstream GitHub Actions result is claimed here; the above validation was run directly against the repository and the production candidate.
Related to the long-running memory report in #55.