feat: add Argo CD version check and validation in pre-install hook #462
Conversation
Enhance the pre-install hook to include a version check for Argo CD. This change introduces environment variables for Argo CD service discovery and version validation, ensuring compatibility with the required version constraint. Additionally, update the Dockerfile to install necessary dependencies for the validation process.
| args: | ||
| - cf helm validate --values /job_tmp/values.yaml --namespace ${NAMESPACE} --version ${VERSION} --hook --log-level debug | ||
| args: | ||
| - | |
There was a problem hiding this comment.
If you use VSCode I advise using YAML Embedded Languages languages extension and adding language comment - makes it easier on eyes.
There was a problem hiding this comment.
that's a nice trick. i installed the extension, and added the comment.
There was a problem hiding this comment.
You can also run this code like so: cat argo-platform/merge-queue.yaml | yq '.steps.wait_for_previous_promotion.commands[0]' | bash. Although figuring out variables passed to the script is tricky.
that's a very handy trick, thanks.
|
build fails because of the size of the new image. |
Check this out. I use it for this very repo's lifecycle. |
thanks. I'll give it a go |
Replace the semver command with semver-cli for version validation in the pre-install hook. This change ensures compatibility with the latest versioning standards and improves the reliability of version checks.
|
i switched over to use the semver-cli. on my machine, the image is now 300MB, which seems fine to me. i suspect this is not directly related to the image size, but maybe to some actual problem we may have in the cluster. |
make sure argo-cd is >=2.12 and <3
What
Why
Notes