Skip to content

feat: add condition for probes #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add condition for probes #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/gitops-runtime/templates/_components/cap-app-proxy/_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ spec:
- name: http
containerPort: 8080
readinessProbe:
{{- if .Values.readinessProbe.enabled }}
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
Expand All @@ -66,6 +67,8 @@ spec:
httpGet:
port: http
path: /api/readyz
{{- end }}
{{- if .Values.livenessProbe.enabled }}
livenessProbe:
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.livenessProbe.periodSeconds }}
Expand All @@ -75,6 +78,7 @@ spec:
httpGet:
port: http
path: /api/healthz
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
Expand Down
2 changes: 2 additions & 0 deletions charts/gitops-runtime/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@ app-proxy:
allowPrivilegeEscalation: false

readinessProbe:
enabled: true
# -- Minimum consecutive failures for the [probe] to be considered failed after having succeeded.
failureThreshold: 3
# -- Number of seconds after the container has started before [probe] is initiated.
Expand All @@ -570,6 +571,7 @@ app-proxy:
timeoutSeconds: 10

livenessProbe:
enabled: true
# -- Minimum consecutive failures for the [probe] to be considered failed after having succeeded.
failureThreshold: 10
# -- Number of seconds after the container has started before [probe] is initiated.
Expand Down