Updated keyboard shortcuts for explaining and running #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <[email protected]>
|
👋 A new build is available for this PR based on 730ca17. |
chrjorgensen
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
@sebjulliand Great UX improvement! 👍
May I suggest adding a keyboard shortcut for Run all statements, like in ACS?
I have added this manually in my keyboard shortcuts but think this should be enabled by default... WDYT? 🤔
Now that Ctrl-Shift-R is not used for run and explain anymore, maybe we can use it for Run statements from cursor? This would align this extension with ACS even further...
Signed-off-by: Seb Julliand <[email protected]>
|
Thanks @chrjorgensen! I added two more key bindings: What do you think? |
sebjulliand
changed the title
sebjulliand
changed the title
chrjorgensen
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default keyboard shortcuts for
ExplainandRun and Explainaction so they don't overlap with other shortcuts likeRun in new view.Explainisctrl+eRun and Explainisctrl+uRun from cursorisctrl+shift+rRun allisctrl+shift+aThis is consistend with ACS's keybindings.