Added default run all keybind #361 #417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For codefori#361 VSCODE doesn't accept modifer + multiple keys. Went with CTRL+a
worksofliam
changed the title
worksofliam
requested changes
Aug 26, 2025
src/views/results/contributes.json
Outdated
Comment on lines
209
to
210
| "key": "ctrl+a", | ||
| "mac": "cmd+a", |
There was a problem hiding this comment.
We absolutely cannot use Control/Command + A as the keybinding. This is 'select all' in most everything.
You can use the combo of Control/Command + A + R as originally suggested. See how we do it elsewhere in this file.
|
Liam, Control/Command + A + R would be invalid. There are limitations to how many 'keys' can be used in one sequence. Changed it to a key chord -> "ctrl+r a". This would stray a bit away from the other key bindings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #361: