Skip to content

Avoid truncation of large integers #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

janfh
Copy link
Contributor

@janfh janfh commented Apr 16, 2025

Fixes #324

Alternative fix to avoid truncation. Requires node >= 21.

  • Wait until VSCode with Electron 35 and node v22 is released
  • Test changes

Update of Electron and Node can be tracked here:
https://redirect.github.com/microsoft/vscode/pull/245423

Background:

JSON.parse will parse integers to Number (IEEE 754 64-bit float) and is limited to values less than what might be returned from the server. This will cause truncation of values less than -9007199254740991 and greater than 9007199254740991 (Number.MAX_SAFE_INTEGER).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big number and DB2 for i
1 participant