-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added authentication verification through email #398
added authentication verification through email #398
Conversation
@@ -36,7 +36,7 @@ import {firebaseAuth} from "../firebase" | |||
dispatch(login()) | |||
cfaSignIn("google.com").subscribe((user)=>{ | |||
setuserData(user.displayName,user.email,user.photoURL); | |||
|
|||
user.sendEmailVerification(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the way to add a new firebase signIN method. You are actually adding this method to the method that is working for google authentication.
references: https://firebase.google.com/docs/auth/web/password-auth
create a new method to handle email-password auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh! sorry i just re-read it now i know i also need to enable login with email and password other than google sign-in ,right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey are you using django in it ,I do not know django so i tried but i think i am unable to do it. Sorry for wasting time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we are not using django. It should be written in ReactJS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i will try again ,but i think @account/ in accountActions is django when i googled it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick discord chat?
Issue Number
#396
fixes #
Describe the changes you've made
Describe if there is any unusual behavior (Any Warning) of your code(Write
NA
if there isn't)Additional context (OPTIONAL)
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
Checklist
Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route