Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added authentication verification through email #398

Closed
wants to merge 1 commit into from
Closed

added authentication verification through email #398

wants to merge 1 commit into from

Conversation

YashKamboj
Copy link

@YashKamboj YashKamboj commented Sep 1, 2021

Issue Number
#396
fixes #

Describe the changes you've made

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Additional context (OPTIONAL)

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review
Preview: Deploy preview link here with the appropriate route

@@ -36,7 +36,7 @@ import {firebaseAuth} from "../firebase"
dispatch(login())
cfaSignIn("google.com").subscribe((user)=>{
setuserData(user.displayName,user.email,user.photoURL);

user.sendEmailVerification();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way to add a new firebase signIN method. You are actually adding this method to the method that is working for google authentication.

references: https://firebase.google.com/docs/auth/web/password-auth
create a new method to handle email-password auth

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh! sorry i just re-read it now i know i also need to enable login with email and password other than google sign-in ,right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey are you using django in it ,I do not know django so i tried but i think i am unable to do it. Sorry for wasting time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we are not using django. It should be written in ReactJS

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i will try again ,but i think @account/ in accountActions is django when i googled it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick discord chat?

@YashKamboj YashKamboj closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants