Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lint Action GitHub action #90

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

zeborg
Copy link
Contributor

@zeborg zeborg commented Jun 14, 2021

Description

Added Lint Action GitHub action with Prettier integration to lint and autofix code styling issues.

Related Issue

Fixes #81

Type of Change:

  • New Feature

How Has This Been Tested?

Tested on my forked repository.

Checklist:

  • Pull request is made against development branch.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings

@zeborg
Copy link
Contributor Author

zeborg commented Jun 14, 2021

I guess I need someone to make a dummy PR to my forked repo in order to test if it's gonna be functional once it's merged into the upstream.

@mdpial I hope you won't mind assisting me here 🙏

@piall
Copy link
Contributor

piall commented Jun 14, 2021

Yes. Of course. It will be delightful. But you can make your own PR in your forked repo. Make a duplicate of this branch locally then add/make some code with ESLint problems and push it. causefolio will be selected as a head repo by default, select your own forked repo from the drop-down, and create a pull request.
image
It will create PR in your forked repo then. I am a little busy with other things right now. If you unable to do that I will make a PR in your forked repo.

@zeborg
Copy link
Contributor Author

zeborg commented Jun 14, 2021

@mdpial I've been doing the exact same thing since yesterday during my testing and it was working well all the time, but once I made the PR here it failed.

I've read about the error that's being shown here, and it's somehow related to the permissions provided by the GitHub token which I couldn't grasp that well, so I felt like maybe it worked for me because I was the owner of the repo itself with all the permissions to it.

But thanks, I'll try some other way to figure it out!

@piall
Copy link
Contributor

piall commented Jun 14, 2021

@zeborg Yes. Because of that reason failing. I had also faced the same issue while working for another repo. After lots of trial and error, I had found this action. Which didn't have any permission related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create github action for running lint on code and show errors
3 participants