Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

feat: add new eslint and prettier rules #130

Conversation

bklynate
Copy link
Contributor

@bklynate bklynate commented Oct 7, 2020

@bklynate
Copy link
Contributor Author

bklynate commented Oct 7, 2020

@maverick-27

@Abhishek-kumar09
Copy link
Contributor

@bklynate Will you make another commit within this PR and run npm run format on that to see what are the changes that have introduced with this PR.

@Abhishek-kumar09
Copy link
Contributor

I guess it was already prompting to add semicolon.

@bklynate
Copy link
Contributor Author

bklynate commented Oct 7, 2020

I ran npm run format.The code was well written and contained semi-colons already. I looked at 10 files and saw no issues but the rules were still missing - good to formally enforce @Abhishek-kumar09

@bklynate
Copy link
Contributor Author

@Abhishek-kumar09 @maverick-27 - will this PR get merged?

@Abhishek-kumar09
Copy link
Contributor

Abhishek-kumar09 commented Oct 13, 2020

Really sorry for the delay!
Yes, it will be reviewed by the project maintainer then be merged. I am adding it to hacktoberfest label incase you were looking for that in this PR. We are currently busy with designs implementation for the new pages and other such stuffs, though your PR is remarkable.

@KeenWarrior KeenWarrior merged commit 7ff4008 into codeforcauseorg:development Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants