Skip to content

Conversation

HuanFengYeh
Copy link
Collaborator

@HuanFengYeh HuanFengYeh commented Sep 29, 2025

Summary

This PR add a new search component to the Transcriptions view, allowing users to filter transcript paragraphs based on a search term. It filters data client-side from existing fetched transcripts.

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

Desktop
Screenshot 2025-10-08 at 8 10 59 AM
Screenshot 2025-10-08 at 8 10 48 AM

Mobile
Screenshot 2025-10-08 at 8 10 38 AM
Screenshot 2025-10-08 at 8 10 33 AM

Known issues

Search is basic keyword matching and does not support advanced features.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Navigate to a hearing page(/hearing/5265)
  2. Ensure the transcript loads and displays paragraphs with timestamps.
    3, Enter a search term in the "search term place holder".
  3. Verify that only matching paragraphs are shown, with the search term highlighted in yellow.
  4. Clear the search input and confirm all paragraphs reappear.
  5. Scroll through the transcript and ensure the search bar remains fixed at the top, not scrolling away.
  6. Enter a non-matching term and confirm the "No results found" message appears.

Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
maple-dev Ready Ready Preview Comment Oct 8, 2025 0:17am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - we just need to fix the translation strings and this should be ready to merge. Thanks for tackling this!

<SearchInput
type="text"
placeholder={
t("search_placeholder", { ns: "hearing" }) || "Search..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It looks like we still need to update the translation json file to have these keys - placeholder/no_results are currently only available under the search json (for the main bill/testimony search pages), so we need to add this to the hearing translation json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants