Skip to content

Notification Testing #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kiminkim724
Copy link
Collaborator

@kiminkim724 kiminkim724 commented Mar 12, 2025

Summary

  • Created Integration tests for notifications
    • Checks for when you follow/unfollow users, orgs, and bills
    • Checks for TestimonySubmissionNotification when testimony is created for a bill/org/user you follow
    • Checks for BillHistoryNotification when Bill History is updated
  • Updated Bill Types to ensure consistent types between front-end and back-end

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Add some screenshots highlighting your changes.

Known issues

  • Tests are very flaky; tried to prevent this using timeouts and onSnapshot in Firebase, but I was unable to get consistent results
    • Flaky tests are mainly the TestimonySubmissionNotificationEvents

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Run yarn test:integration notifications.test.ts

Copy link

vercel bot commented Mar 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 0:50am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant