Skip to content

⚡️ Speed up function get_root_nodes by 140% #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_root_nodes by 140% #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions llama-index-core/llama_index/core/node_parser/relational/hierarchical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ def get_leaf_nodes(nodes: List[BaseNode]) -> List[BaseNode]:

def get_root_nodes(nodes: List[BaseNode]) -> List[BaseNode]:
"""Get root nodes."""
root_nodes = []
for node in nodes:
if NodeRelationship.PARENT not in node.relationships:
root_nodes.append(node)
return root_nodes
# Optimize by using list comprehension and local variable for NodeRelationship.PARENT
parent_rel = NodeRelationship.PARENT
return [node for node in nodes if parent_rel not in node.relationships]


def get_child_nodes(nodes: List[BaseNode], all_nodes: List[BaseNode]) -> List[BaseNode]:
Expand Down