Skip to content

⚡️ Speed up method Serializeable.from_dict by 24% #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Serializeable.from_dict by 24% #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions guardrails/classes/generic/serializeable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,14 @@ class Serializeable:
@classmethod
def from_dict(cls, data: Dict[str, Any]):
annotations = get_annotations(cls)
attributes = dict.keys(annotations)
snake_case_kwargs = {
snake_case(k): data.get(k) for k in data if snake_case(k) in attributes
}
snake_case_kwargs["encoder"] = snake_case_kwargs.get(
"encoder", SerializeableJSONEncoder
)
# Convert the keys of annotations dict to a set for faster lookup
attributes = set(annotations)
# Precompute snake_case for each input key, avoid repeated computation in the comprehension
sc_data = {snake_case(k): v for k, v in data.items()}
# Only keep those that are present in attributes
snake_case_kwargs = {k: v for k, v in sc_data.items() if k in attributes}
# Use setdefault to avoid recomputing key and ensure compatible default
snake_case_kwargs.setdefault("encoder", SerializeableJSONEncoder)
return cls(**snake_case_kwargs) # type: ignore

@property
Expand Down