Skip to content

⚡️ Speed up method Unknown_Config.from_model_on_disk by 147% #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Unknown_Config.from_model_on_disk by 147% #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions invokeai/backend/model_manager/configs/unknown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from copy import deepcopy
from typing import Any, Literal, Self
from typing import Any, Literal

from pydantic import Field
from typing_extensions import Self

from invokeai.app.services.config.config_default import get_config
from invokeai.backend.model_manager.configs.base import Config_Base
Expand Down Expand Up @@ -30,7 +30,8 @@ def from_model_on_disk(cls, mod: ModelOnDisk, override_fields: dict[str, Any]) -
performed by ModelConfigFactory before this method is called.
"""

cloned_override_fields = deepcopy(override_fields)
# Avoid deepcopy for shallow removal of specific keys; dict.copy is sufficient and much faster
cloned_override_fields = override_fields.copy()
cloned_override_fields.pop("base", None)
cloned_override_fields.pop("type", None)
cloned_override_fields.pop("format", None)
Expand Down