bundle analysis handle ingest call to return bundle name and allow sending compare sha param #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySentry
commented
Aug 13, 2024
requirements.in
Outdated
| @@ -1,5 +1,5 @@ | |||
| https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem | |||
| https://github.com/codecov/shared/archive/1482593343604028ffee5902da080696eb8c14d4.tar.gz#egg=shared | |||
| https://github.com/codecov/shared/archive/bc2f6f9edc2bae6066b736c2ee43a5f81c5ea008.tar.gz#egg=shared | |||
There was a problem hiding this comment.
These values will be updated to the shared commit SHA on main once its corresponding shared PR is merged.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36562 36565 +3
=======================================
+ Hits 35881 35884 +3
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36562 36565 +3
=======================================
+ Hits 35881 35884 +3
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 438 438
Lines 36562 36565 +3
=======================================
+ Hits 35881 35884 +3
Misses 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 473 473
Lines 37767 37770 +3
=======================================
+ Hits 37072 37075 +3
Misses 695 695
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JerrySentry
changed the title
adrian-codecov
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the bundle name of the processed bundle stat file, and attach it to the processing result json. This will be useful for optimizing timeseries measurements in this task [ref][Shared/Worker] Refactor ingest to return a bundle_name to know which bundle to save measurements for engineering-team#1875.
If compareSha present in params of uploader task, send that to the BA ingest function. closes [PreMergeCommit][Worker] BA Processor task - if there is compareSha provided, save it into SQLite engineering-team#2006. closes [PreMergeCommit][Worker] Upload task pass compareSha to BA processor task engineering-team#2007
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.