Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github checks annotations #1052

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix github checks annotations #1052

merged 1 commit into from
Jan 31, 2025

Conversation

nora-codecov
Copy link
Contributor

@nora-codecov nora-codecov commented Jan 30, 2025

two problems, one pr:

sentry issue related to handling of this field

flips default on annotations from True to False codecov/engineering-team#3295

@nora-codecov nora-codecov requested a review from a team January 30, 2025 21:58
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (6302730) to head (190cc01).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files         462      462           
  Lines       37902    37922   +20     
=======================================
+ Hits        36963    36986   +23     
+ Misses        939      936    -3     
Flag Coverage Δ
integration 42.87% <4.76%> (-0.02%) ⬇️
unit 90.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@nora-codecov nora-codecov added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 6b0c691 Jan 31, 2025
38 of 40 checks passed
@nora-codecov nora-codecov deleted the nora/1626-bug branch January 31, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants