Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ref][Shared/Worker] Refactor ingest to return a bundle_name to know which bundle to save measurements for #1875

Open
Tracked by #1413
JerrySentry opened this issue Jun 7, 2024 · 0 comments · May be fixed by codecov/worker#723
Assignees

Comments

@JerrySentry
Copy link

JerrySentry commented Jun 7, 2024

currently we upsert measurements for all bundles when processing a single bundle, for example:
this commit has a bundle_analysis_report with 3 bundles (B1, B2, B3), when processing B1, we should only upsert measurements for B1, instead we currently do it for B1, B2, B3. The correctness is the same, but its doing extra work for nothing and taking longer that it should and more traffic

the change would be for the processor to return the bundle name that was processed and pass it to the save measurements task so it will only do it for this bundle name

@JerrySentry JerrySentry self-assigned this Jun 13, 2024
@JerrySentry JerrySentry changed the title [Shared/Worker] Refactor ingest to return a bundle_name to know which bundle to save measurements for [ref][Shared/Worker] Refactor ingest to return a bundle_name to know which bundle to save measurements for Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant