remove FeatureExposure and SimpleMetric models #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Sentry found no issues in your recent changes ✅ |
adrian-codecov
approved these changes
Mar 12, 2025
matt-codecov
force-pushed
the
matt/remove-sql-metrics
branch
from
e493f09 to
84e8828
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## matt/remove-exposure-logging #571 +/- ##
=============================================================
Coverage 88.89% 88.89%
=============================================================
Files 462 463 +1
Lines 13199 13171 -28
Branches 1513 1511 -2
=============================================================
- Hits 11733 11709 -24
+ Misses 1145 1141 -4
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
actually this needs to be two PRs. we need to remove the exposure logging, ship in both worker and api, and then we can remove the table |
matt-codecov
force-pushed
the
matt/remove-sql-metrics
branch
from
84e8828 to
024c5ba
Compare
matt-codecov
changed the title
CodSpeed Performance ReportMerging #571 will not alter performanceComparing Summary
|
matt-codecov
force-pushed
the
matt/remove-sql-metrics
branch
from
024c5ba to
04493d2
Compare
matt-codecov
changed the title
Swatinem
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these were never really fleshed out so i am deleting them
if we want to re-add them in the future, we need to do it with partitioning
requires #573 to ship in worker and api before this can merge
also requires codecov/worker#1136 to have shipped in worker, but that's already merged
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.