feat: Add Amplitude event publisher #487
Open
+342
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmurray-codecov
force-pushed
the
spalmurray/amplitude
branch
from
2714017 to
e9d093e
Compare
spalmurray-codecov
changed the title
spalmurray-codecov
force-pushed
the
spalmurray/amplitude
branch
from
7b14aea to
f78b4ce
Compare
spalmurray-codecov
changed the title
ajay-sentry
reviewed
Jan 30, 2025
shared/events/base.py
Outdated
| from abc import ABC, abstractmethod | ||
|
|
||
|
|
||
| class EventPublisherPropertyException(Exception): |
There was a problem hiding this comment.
MissingEventPropertyException
spalmurray-codecov
force-pushed
the
spalmurray/amplitude
branch
from
e976622 to
f9704e0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 90.34% 89.97% -0.37%
==========================================
Files 437 324 -113
Lines 12951 9048 -3903
Branches 2104 1599 -505
==========================================
- Hits 11700 8141 -3559
+ Misses 1133 846 -287
+ Partials 118 61 -57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
EventPublisherabstraction and an implementation of it inAmplitudeEventPublisher.EventPublisheris meant to be extremely generic and could be reused for any types of events we may want to publish in the future (TaskServicecould be converted to anEventPublisher, for example).The Amplitude implementation defines some starting events and their payloads. These will be used in a future API PR, once we have the API key set as an environment variable.
Closes codecov/engineering-team#2893