Skip to content

feat: Remove plan feedback banners #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calvin-codecov wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Remove plan feedback banners #4005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e9a0c6
feat: Remove plan feedback banners
calvin-codecov Jun 17, 2026
74244a1
test: Update tests
calvin-codecov Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions src/shared/GlobalTopBanners/GlobalTopBanners.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ import GlobalTopBanners from './GlobalTopBanners'
vi.mock('./TrialBanner', () => ({
default: () => 'TrialBanner',
}))
vi.mock('./TeamPlanFeedbackBanner', () => ({
default: () => 'TeamPlanFeedbackBanner',
}))
vi.mock('./ProPlanFeedbackBanner', () => ({
default: () => 'ProPlanFeedbackBanner',
}))
vi.mock('./BundleFeedbackBanner', () => ({
default: () => 'BundleFeedbackBanner',
}))
Expand All @@ -32,24 +26,10 @@ describe('GlobalTopBanners', () => {
expect(banner).toBeInTheDocument()
})

it('renders team plan feedback banner', async () => {
render(<GlobalTopBanners />)

const banner = await screen.findByText(/TeamPlanFeedbackBanner/)
expect(banner).toBeInTheDocument()
})

it('renders pro plan feedback banner', async () => {
render(<GlobalTopBanners />)

const banner = await screen.findByText(/ProPlanFeedbackBanner/)
expect(banner).toBeInTheDocument()
})

it('renders bundle feedback banner', async () => {
render(<GlobalTopBanners />)

const banner = await screen.findByText(/ProPlanFeedbackBanner/)
const banner = await screen.findByText(/BundleFeedbackBanner/)
expect(banner).toBeInTheDocument()
})

Expand Down
10 changes: 0 additions & 10 deletions src/shared/GlobalTopBanners/GlobalTopBanners.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import SilentNetworkErrorWrapper from 'layouts/shared/SilentNetworkErrorWrapper'
import AnnouncementBanner from './AnnouncementBanner'
import BundleFeedbackBanner from './BundleFeedbackBanner'
import OktaBanners from './OktaBanners'
import ProPlanFeedbackBanner from './ProPlanFeedbackBanner'
import TeamPlanFeedbackBanner from './TeamPlanFeedbackBanner'
import TokenlessBanner from './TokenlessBanner'
import TrialBanner from './TrialBanner'

Expand All @@ -24,14 +22,6 @@ const GlobalTopBanners: React.FC = () => {
<TrialBanner />
</SilentNetworkErrorWrapper>

<SilentNetworkErrorWrapper>
<TeamPlanFeedbackBanner />
</SilentNetworkErrorWrapper>

<SilentNetworkErrorWrapper>
<ProPlanFeedbackBanner />
</SilentNetworkErrorWrapper>

<SilentNetworkErrorWrapper>
<BundleFeedbackBanner />
</SilentNetworkErrorWrapper>
Expand Down
158 changes: 0 additions & 158 deletions src/shared/GlobalTopBanners/ProPlanFeedbackBanner/ProPlanFeedbackBanner.test.tsx
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions src/shared/GlobalTopBanners/ProPlanFeedbackBanner/ProPlanFeedbackBanner.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/shared/GlobalTopBanners/ProPlanFeedbackBanner/index.ts
View file
Open in desktop

This file was deleted.

Loading
Loading