fix: Correct URI encoding for tree view paths#4003
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
|
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 268 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Collaborator
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a
URIErrorthat occurred when navigating to tree views with pathnames containing literal%characters, such as Copier template syntax ([% if py3 %]).The root cause was that path segments were not correctly encoded before being passed to React Router's Link component, leading to
decodeURIfailing on invalid percent-encoded sequences.The solution involves modifying the
pathfunctions forcommitTreeView,pullTreeView, andtreeViewinsrc/services/navigation/useNavLinks.ts. Each path segment is now individually encoded usingencodeURIComponentto ensure special characters are properly handled, while preserving/as path separators. This prevents theURIErrorand allows correct navigation to these paths.Code Example
No code example provided in the description.
Notable Changes
pathfunctions forcommitTreeView,pullTreeView, andtreeViewinsrc/services/navigation/useNavLinks.ts.encodeURIComponentfor each path segment to correctly handle special characters like%.URIErrorwhen navigating to tree views with percent characters in pathnames.Screenshots
No screenshots provided in the description.
Link to Sample Entry
No link to a sample entry provided in the description.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes GAZEBO-1806