fix: Normalize flags query param to array in TitleFlags#4002
Open
sentry[bot] wants to merge 1 commit into
Open
fix: Normalize flags query param to array in TitleFlags#4002sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
|
Bundle ReportChanges will increase total bundle size by 58 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Collaborator
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses GAZEBO-1802, a
TypeError: b.forEach is not a functionoccurring insrc/ui/FileViewer/ToggleHeader/Title/Title.tsx.Code Example
Notable Changes
Root Cause:
The
useLocationParamshook, which utilizesqs.parse, returns a plain string for single-value query parameters (e.g.,?flags=some-flag-name) instead of an array. This string then overwrites the default empty array forparams.flags. Whenparams?.flags?.forEach()is subsequently called, it attempts to invokeforEachon a string, leading to theTypeError.Solution:
LocationParamstype to correctly reflect thatparams.flagscan be either astringorstring[]as returned byqs.parse.flagsParamvariable within theTitleFlagscomponent. This variable usesArray.isArray()to ensure thatparams.flagsis always coerced into an array, regardless of whetherqs.parsereturned a string or an array.useStateinitialization forselectedFlagsand the.forEach()call to use the newly normalizedflagsParam. This guarantees that.forEach()is always called on an array, preventing theTypeError.This fix is localized to the
TitleFlagscomponent, ensuring that theforEachoperation is always performed on a valid array without introducing global changes touseLocationParams.Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes GAZEBO-1802