fix: Handle NotFoundError gracefully on pull page#3986
Draft
sentry[bot] wants to merge 1 commit into
Draft
Conversation
Author
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
|
Author
Bundle ReportChanges will decrease total bundle size by 1 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses GAZEBO-17YY, where users encountered an unhandled JavaScript error (minified as "Error: fe") when navigating to a pull request page for a repository that does not exist in Codecov.
Code Example
PullPageDataQueryOptsuseSuspenseQueryV5rejectNetworkErrorPullRequestPage.tsxif (!isPending && !data?.pull) return <NotFound />Notable Changes
Root Cause:
The
PullPageDataQueryOptsquery, used byuseSuspenseQueryV5inPullRequestPage.tsx, was callingrejectNetworkErrorwhen aNotFoundErrorwas returned by the GraphQL API. In suspense mode,useSuspenseQueryV5re-throws rejected promises during render, leading to an unhandled exception because there was no error boundary specifically catching this type of rejection on the pull page.Solution:
Instead of calling
rejectNetworkErrorwhenPullPageDataQueryOptsreceives aNotFoundErrorfrom the GraphQL API, the query now returnsnullforpull,coverageEnabled, andbundleAnalysisEnabledfields. This allows the existing null-check (if (!isPending && !data?.pull) return <NotFound />) inPullRequestPage.tsxto correctly identify the non-existent repository and render the<NotFound />component gracefully, preventing the unhandled error.Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes GAZEBO-17YY