fix: Extra x's when replacing / hiding tokens #3740
Conversation
Bundle ReportChanges will decrease total bundle size by 2 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Bundle ReportChanges will decrease total bundle size by 2 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3740 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 823 823
Lines 14863 14863
Branches 4229 4229
=======================================
Hits 14692 14692
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3740 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 823 823
Lines 14863 14863
Branches 4229 4229
=======================================
Hits 14692 14692
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3740 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 823 823
Lines 14863 14863
Branches 4229 4229
=======================================
Hits 14692 14692
Misses 165 165
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR aims to fix some weird behavior when hiding org upload tokens where an extra character was being added to the end of each pattern due to the "|" operator being present and comparing the last character in each sequence, an empty "" and converting that character to an "x" as well.
We just remove the "|" and we're good
Closes https://github.com/codecov/internal-issues/issues/174
Screenshots
BEFORE
Screen.Recording.2025-02-13.at.3.28.13.PM.mov
AFTER
Screen.Recording.2025-02-13.at.3.26.50.PM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.