-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ACH payment method #3616
Open
suejung-sentry
wants to merge
13
commits into
main
Choose a base branch
from
sshin/3108
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
34bfe3e
feat: Add ACH payment method
suejung-sentry 1a8560e
wip
suejung-sentry f428955
Merge remote-tracking branch 'origin/main' into sshin/3108
suejung-sentry 0f6d1c3
add stripe payment element
suejung-sentry 0c413de
cleanup
suejung-sentry 747f183
Merge remote-tracking branch 'origin/main' into sshin/3108
suejung-sentry 8912835
wip
suejung-sentry a59427f
use the graphql endpoint, fix some tests
suejung-sentry 616eaa8
fix tests
suejung-sentry 6e35b3b
Merge remote-tracking branch 'origin/main' into sshin/3108
suejung-sentry eaaf86d
fix tests
suejung-sentry 4aacfb6
Merge remote-tracking branch 'origin/main' into sshin/3108
suejung-sentry 2dc8211
fix tests
suejung-sentry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 0 additions & 112 deletions
112
src/pages/PlanPage/subRoutes/CurrentOrgPlan/BillingDetails/Address/AddressCard.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
import { useState } from 'react' | ||
import { useParams } from 'react-router-dom' | ||
|
||
import { useAccountDetails } from 'services/account' | ||
import A from 'ui/A' | ||
import Button from 'ui/Button' | ||
|
||
import AddressCard from './Address/AddressCard' | ||
import EditPaymentMethods from './EditPaymentMethods' | ||
import EmailAddress from './EmailAddress' | ||
import PaymentCard from './PaymentCard' | ||
import { ViewPaymentMethod } from './ViewPaymentMethod' | ||
|
||
// Remove this when we build Secondary Payment Method feature | ||
export const SECONDARY_PAYMENT_FEATURE_ENABLED = false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This flag can get removed when we build out the rest of the secondary payment method feature (next quarter) |
||
|
||
interface URLParams { | ||
provider: string | ||
|
@@ -18,34 +24,86 @@ function BillingDetails() { | |
owner, | ||
}) | ||
const subscriptionDetail = accountDetails?.subscriptionDetail | ||
const [isEditMode, setEditMode] = useState(false) | ||
|
||
const secondaryPaymentFeatureEnabled = SECONDARY_PAYMENT_FEATURE_ENABLED | ||
|
||
if (!subscriptionDetail) { | ||
return null | ||
} | ||
|
||
return ( | ||
<div className="flex flex-col border"> | ||
<h3 className="p-4 font-semibold">Billing details</h3> | ||
<EmailAddress /> | ||
<PaymentCard | ||
// @ts-expect-error - TODO fix this once we update PaymentCard to TS | ||
subscriptionDetail={subscriptionDetail} | ||
provider={provider} | ||
owner={owner} | ||
/> | ||
<AddressCard | ||
subscriptionDetail={subscriptionDetail} | ||
provider={provider} | ||
owner={owner} | ||
/> | ||
{subscriptionDetail.taxIds.length > 0 ? ( | ||
<div className="flex flex-col gap-2 p-4"> | ||
<h4 className="font-semibold">Tax ID</h4> | ||
{subscriptionDetail.taxIds.map((val, index) => ( | ||
<p key={index}>{val?.value}</p> | ||
))} | ||
<div className="flex flex-col divide-y border"> | ||
{/* Billing Details Section */} | ||
<div className="flex items-center justify-between gap-4 p-4"> | ||
<div> | ||
<h3 className="font-semibold">Billing details</h3> | ||
<p className="pt-1 text-xs text-ds-gray-octonary"> | ||
You can modify your billing details. To update your tax IDs, please{' '} | ||
{/* @ts-expect-error ignore until we can convert A component to ts */} | ||
<A to={{ pageName: 'support' }} variant="link"> | ||
contact support | ||
</A> | ||
</p> | ||
</div> | ||
) : null} | ||
{!isEditMode ? ( | ||
<Button | ||
hook="button" | ||
onClick={() => setEditMode(true)} | ||
variant="default" | ||
className="flex-none" | ||
> | ||
Edit payment | ||
</Button> | ||
) : ( | ||
<Button | ||
hook="button" | ||
onClick={() => setEditMode(false)} | ||
variant="default" | ||
className="flex-none" | ||
> | ||
Back | ||
</Button> | ||
)} | ||
</div> | ||
{isEditMode ? ( | ||
<EditPaymentMethods | ||
setEditMode={setEditMode} | ||
provider={provider} | ||
owner={owner} | ||
existingSubscriptionDetail={subscriptionDetail} | ||
/> | ||
) : ( | ||
<> | ||
<EmailAddress /> | ||
<ViewPaymentMethod | ||
heading="Primary Payment Method" | ||
isPrimaryPaymentMethod={true} | ||
setEditMode={setEditMode} | ||
subscriptionDetail={subscriptionDetail} | ||
provider={provider} | ||
owner={owner} | ||
/> | ||
{secondaryPaymentFeatureEnabled && ( | ||
<ViewPaymentMethod | ||
heading="Secondary Payment Method" | ||
isPrimaryPaymentMethod={false} | ||
setEditMode={setEditMode} | ||
subscriptionDetail={subscriptionDetail} | ||
provider={provider} | ||
owner={owner} | ||
/> | ||
)} | ||
{subscriptionDetail?.taxIds?.length ? ( | ||
<div className="flex flex-col gap-2 p-4"> | ||
<h4 className="font-semibold">Tax ID</h4> | ||
{subscriptionDetail?.taxIds?.map((val, index) => ( | ||
<p key={index}>{val?.value}</p> | ||
))} | ||
</div> | ||
) : null} | ||
</> | ||
)} | ||
</div> | ||
) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Theme was getting duped and passed in both the AddressForm and CreditCardForm before, so I consolidated them in file stripe.ts