Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ACH payment method #3616

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+2,041 −1,181

fix tests

2dc8211
Select commit
Loading
Failed to load commit list.
Open

feat: Add ACH payment method #3616

fix tests
2dc8211
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 14, 2025 in 0s

98.80% (-0.14%) compared to 333b4e9

View this Pull Request on Codecov

98.80% (-0.14%) compared to 333b4e9

Details

Codecov Report

Attention: Patch coverage is 85.97561% with 23 lines in your changes missing coverage. Please review.

Project coverage is 98.80%. Comparing base (333b4e9) to head (2dc8211).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gDetails/EditPaymentMethods/EditPaymentMethods.tsx 63.63% 8 Missing ⚠️
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 64.28% 5 Missing ⚠️
...PaymentMethods/PaymentMethod/PaymentMethodForm.tsx 78.94% 4 Missing ⚠️
...ingDetails/ViewPaymentMethod/ViewPaymentMethod.tsx 66.66% 3 Missing ⚠️
...llingDetails/ViewPaymentMethod/Address/Address.tsx 91.66% 2 Missing ⚠️
src/services/account/useUpdatePaymentMethod.ts 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3616      +/-   ##
==========================================
- Coverage   98.94%   98.80%   -0.14%     
==========================================
  Files         815      820       +5     
  Lines       14676    14752      +76     
  Branches     4164     4210      +46     
==========================================
+ Hits        14521    14576      +55     
- Misses        148      170      +22     
+ Partials        7        6       -1
Files with missing lines Coverage Δ
src/pages/PlanPage/PlanPage.jsx 100.00% <100.00%> (ø)
...Details/EditPaymentMethods/Address/AddressForm.tsx 91.66% <100.00%> (ø)
...iewPaymentMethod/PaymentMethod/BankInformation.tsx 100.00% <100.00%> (ø)
...iewPaymentMethod/PaymentMethod/CardInformation.tsx 100.00% <100.00%> (ø)
.../ViewPaymentMethod/PaymentMethod/PaymentMethod.tsx 100.00% <100.00%> (ø)
src/services/account/useAccountDetails.ts 95.23% <ø> (ø)
src/services/account/useCreateStripeSetupIntent.ts 100.00% <100.00%> (ø)
src/services/account/useUpdateBillingEmail.ts 100.00% <ø> (ø)
src/shared/ThemeContext/ThemeContext.tsx 96.87% <100.00%> (+0.10%) ⬆️
src/shared/utils/billing.ts 100.00% <100.00%> (ø)
... and 8 more
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.41% <79.43%> (-0.24%) ⬇️
Services 99.31% <96.77%> (-0.03%) ⬇️
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333b4e9...2dc8211. Read the comment docs.

View more details on Codecov