Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output number of network files found #625

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

Flamefire
Copy link
Contributor

This information is useful to verify that the FileFinders worked as expected and file-fixes will be done correctly.

This information is useful to verify that the FileFinders worked as expected and file-fixes will be done correctly.
Copy link

sentry-io bot commented Feb 14, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: codecov_cli/services/upload/upload_collector.py

Function Unhandled Issue
generate_upload_data TypeError: can only concatenate list (not "tuple") to list codecov_cli.services.upload.file_finder in ...
Event Count: 12

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.31%. Comparing base (6e8e1b1) to head (5f1d3b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   94.40%   94.31%   -0.10%     
==========================================
  Files          90       87       -3     
  Lines        3359     3358       -1     
==========================================
- Hits         3171     3167       -4     
- Misses        188      191       +3     
Flag Coverage Δ
python3.10 ?
python3.11 ?
python3.12 94.88% <100.00%> (+<0.01%) ⬆️
python3.13 ?
python3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrockhu-codecov thomasrockhu-codecov merged commit 278bec7 into codecov:main Feb 18, 2025
21 of 22 checks passed
@Flamefire Flamefire deleted the patch-1 branch February 18, 2025 11:31
Copy link

sentry-io bot commented Feb 19, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: object of type 'NoneType' has no len() Upload Coverage View Issue
  • ‼️ TypeError: object of type 'NoneType' has no len() Do Upload View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants