Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: glob backward compatibility #4775

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

fix: glob backward compatibility #4775

wants to merge 2 commits into from

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Description of this PR, which problem it solves
  • Resolves #issueId (if applicable).

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent requested a review from DavertMik January 22, 2025 06:58
@kobenguyent
Copy link
Collaborator Author

published as [email protected] for testing.

@DavertMik
Copy link
Contributor

I'm not sure if we use it correctly:

image

In 10-11 our glob = require('glob') probably won't work

https://github.com/isaacs/node-glob/blob/main/changelog.md#1000

DavertMik
DavertMik requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this notation, but we need to ensure we use compatible glob version

Also I'm concerned that we can actually use glob from v11 because of no named exports

package.json Outdated Show resolved Hide resolved
@kobenguyent @DavertMik
Update package.json
368b6e4 
Co-authored-by: Michael Bodnarchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobenguyent @DavertMik